Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: runtime/vm/scavenger.cc

Issue 238063011: Modify the Weak Reference Set creation API to make it easier to create (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/gc_marker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
===================================================================
--- runtime/vm/scavenger.cc (revision 35132)
+++ runtime/vm/scavenger.cc (working copy)
@@ -527,7 +527,6 @@
visitor->VisitPointer(reference_set->get_value(v));
}
is_unreachable = false;
- delete reference_set;
break;
Ivan Posva 2014/04/17 23:47:44 ditto
siva 2014/04/21 18:04:14 Done.
}
}
@@ -545,14 +544,9 @@
break;
}
}
- // Deallocate any unreachable references on the delay queue.
- if (state->delayed_weak_reference_sets() != NULL) {
- WeakReferenceSet* queue = state->delayed_weak_reference_sets();
- state->set_delayed_weak_reference_sets(NULL);
- while (queue != NULL) {
- delete WeakReferenceSet::Pop(&queue);
- }
- }
+ // All weak reference sets are zone allocated and unmarked references on
+ // the delay queue will be freed when the zone is released in the epilog
+ // callback.
}
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/gc_marker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698