Modify the Weak Reference Set creation API to make it easier to create

runtime/vm/gc_marker.cc

Index: runtime/vm/gc_marker.cc
===================================================================
--- runtime/vm/gc_marker.cc	(revision 35132)
+++ runtime/vm/gc_marker.cc	(working copy)
@@ -374,7 +374,6 @@
             visitor->VisitPointer(reference_set->get_value(v));
           }
           is_unreachable = false;
-          delete reference_set;
           break;

[Ivan Posva, 2014/04/17 23:47:44]

Please add a comment that this break is breaking out of the loop iterating over
the weak reference values in the set and not out of the overall handling.

[siva, 2014/04/21 18:04:14]

Done.

         }
       }
@@ -392,14 +391,9 @@
       break;
     }
   }
-  // Deallocate any unmarked references on the delay queue.
-  if (state->delayed_weak_reference_sets() != NULL) {
-    WeakReferenceSet* queue = state->delayed_weak_reference_sets();
-    state->set_delayed_weak_reference_sets(NULL);
-    while (queue != NULL) {
-      delete WeakReferenceSet::Pop(&queue);
-    }
-  }
+  // All weak reference sets are zone allocated and unmarked references on
+  // the delay queue will be freed when the zone is released in the epilog
+  // callback.
 }