Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2380583003: VM: Fix NoSuchMethod invocation interrupted by shutdown. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix NoSuchMethod invocation interrupted by shutdown. When shut down while processing a NoSuchMethod invocation in the runtime, we forgot to check for an error result after allocating the invocation mirror. BUG=#26588 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/fc50f7ad01829cf219251e69c06cba1d7166e4b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/dart_entry.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 2 months ago (2016-09-28 21:32:38 UTC) #2
zra
good catch! lgtm
4 years, 2 months ago (2016-09-28 21:35:54 UTC) #3
Florian Schneider
4 years, 2 months ago (2016-09-28 21:52:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc50f7ad01829cf219251e69c06cba1d7166e4b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698