Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: runtime/vm/dart_entry.cc

Issue 2380583003: VM: Fix NoSuchMethod invocation interrupted by shutdown. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
diff --git a/runtime/vm/dart_entry.cc b/runtime/vm/dart_entry.cc
index c9e7769fba4a0b47400b6ee8dfcaf4302c9ab65f..f78dc3ca37c9da385e1836ef519b4ca6c7b1010c 100644
--- a/runtime/vm/dart_entry.cc
+++ b/runtime/vm/dart_entry.cc
@@ -243,6 +243,10 @@ RawObject* DartEntry::InvokeNoSuchMethod(const Instance& receiver,
allocation_args.SetAt(3, Bool::False()); // Not a super invocation.
const Object& invocation_mirror = Object::Handle(
InvokeFunction(allocation_function, allocation_args));
+ if (invocation_mirror.IsError()) {
+ Exceptions::PropagateError(Error::Cast(invocation_mirror));
+ UNREACHABLE();
+ }
// Now use the invocation mirror object and invoke NoSuchMethod.
const int kNumArguments = 2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698