kernel->ssa: implement assert statements

kernel->ssa: implement assert statements

R=johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/81e13861fb3d3c1b3c828a815d550052e371e0fd

[Harry Terkelsen, 2016-09-29 00:22:54]

het@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Johnni Winther, 2016-09-29 07:33:49]

lgtm

[Siggi Cherem (dart-lang), 2016-09-29 15:36:52]

lgtm

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:431: // TODO(het): should these be
desugared in a kernel transformation?
maybe - but I think it's possible that we could use assertions to improve static
analysis in the future, so it might be of interest to keep it around until
later.

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:453:
brancher.handleIf(buildCondition, fail, null);
suggestion for later: it seems we always do:

  SsaBranchBuilder branch = new SsaBranchBuilder(this, compiler);
  branch.handleSomething(a, b, c);

It might be worth adding to GraphBuilder some helpers so we don't directly
allocate the BranchBuilder. We could keep the builder/handle divide like:

   addBranch().handleIf(a, b, c);

or we could further simplify it and stop exposing the branch builder if we can:

   addIf(a, b, c);


thoughts?

[Harry Terkelsen, 2016-09-29 21:16:21]

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:431: // TODO(het): should these be
desugared in a kernel transformation?
On 2016/09/29 15:36:52, Siggi Cherem (dart-lang) wrote:
> maybe - but I think it's possible that we could use assertions to improve
static
> analysis in the future, so it might be of interest to keep it around until
> later.

Removed TODO after our team meeting discussing this

https://codereview.chromium.org/2380573004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:453:
brancher.handleIf(buildCondition, fail, null);
On 2016/09/29 15:36:52, Siggi Cherem (dart-lang) wrote:
> suggestion for later: it seems we always do:
> 
>   SsaBranchBuilder branch = new SsaBranchBuilder(this, compiler);
>   branch.handleSomething(a, b, c);
> 
> It might be worth adding to GraphBuilder some helpers so we don't directly
> allocate the BranchBuilder. We could keep the builder/handle divide like:
> 
>    addBranch().handleIf(a, b, c);
> 
> or we could further simplify it and stop exposing the branch builder if we
can:
> 
>    addIf(a, b, c);
> 
> 
> thoughts?

Good idea. I moved these to graph_builder

[Harry Terkelsen, 2016-09-29 21:17:17]

Description was changed from

==========
kernel->ssa: implement assert statements
==========

to

==========
kernel->ssa: implement assert statements

R=johnniwinther@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/81e13861fb3d3c1b3c828a815d550052e371e0fd
==========

[Harry Terkelsen, 2016-09-29 21:17:18]

Committed patchset #3 (id:40001) manually as
81e13861fb3d3c1b3c828a815d550052e371e0fd (presubmit successful).