kernel->ssa: implement assert statements

pkg/compiler/lib/src/ssa/builder_kernel.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../common.dart';
 import '../common/codegen.dart' show CodegenRegistry, CodegenWorkItem;
 import '../common/names.dart';
 import '../common/tasks.dart' show CompilerTask;
@@ skipping 90 matching lines @@
       buildField(target);
     } else if (target is ir.Constructor) {
       buildConstructor(target);
     }
     assert(graph.isValid());
     return graph;
   }
 
   void buildField(ir.Field field) {
     openFunction();
-    field.initializer.accept(this);
+    if (field.initializer != null) {
+      field.initializer.accept(this);
+    } else {
+      stack.add(graph.addConstantNull(compiler));
+    }
     HInstruction value = pop();
     closeAndGotoExit(new HReturn(value, null));
     closeFunction();
   }
 
   @override
   HInstruction popBoolified() {
     HInstruction value = pop();
     // TODO(het): add boolean conversion type check
     HInstruction result = new HBoolify(value, backend.boolType);
@@ skipping 291 matching lines @@
   @override
   void visitIfStatement(ir.IfStatement ifStatement) {
     SsaBranchBuilder brancher = new SsaBranchBuilder(this, compiler);
     brancher.handleIf(
         () => ifStatement.condition.accept(this),
         () => ifStatement.then.accept(this),
         () => ifStatement.otherwise?.accept(this));
   }
 
   @override
+  void visitAssertStatement(ir.AssertStatement assertStatement) {
+    if (!compiler.options.enableUserAssertions) return;
+    if (assertStatement.message == null) {
+      assertStatement.condition.accept(this);
+      // TODO(het): should these be desugared in a kernel transformation?

[Siggi Cherem (dart-lang), 2016/09/29 15:36:52]

maybe - but I think it's possible that we could use assertions to improve static
analysis in the future, so it might be of interest to keep it around until
later.

[Harry Terkelsen, 2016/09/29 21:16:21]

Removed TODO after our team meeting discussing this

+      _pushStaticInvocation(astAdapter.assertHelper, <HInstruction>[pop()],
+          astAdapter.assertHelperReturnType);
+      pop();
+      return;
+    }
+
+    // if (assertTest(condition)) assertThrow(message);
+    void buildCondition() {
+      assertStatement.condition.accept(this);
+      _pushStaticInvocation(astAdapter.assertTest, <HInstruction>[pop()],
+          astAdapter.assertTestReturnType);
+    }
+
+    void fail() {
+      assertStatement.message.accept(this);
+      _pushStaticInvocation(astAdapter.assertThrow, <HInstruction>[pop()],
+          astAdapter.assertThrowReturnType);
+      pop();
+    }
+
+    SsaBranchBuilder brancher = new SsaBranchBuilder(this, compiler);
+    brancher.handleIf(buildCondition, fail, null);

[Siggi Cherem (dart-lang), 2016/09/29 15:36:52]

suggestion for later: it seems we always do:

  SsaBranchBuilder branch = new SsaBranchBuilder(this, compiler);
  branch.handleSomething(a, b, c);

It might be worth adding to GraphBuilder some helpers so we don't directly
allocate the BranchBuilder. We could keep the builder/handle divide like:

   addBranch().handleIf(a, b, c);

or we could further simplify it and stop exposing the branch builder if we can:

   addIf(a, b, c);


thoughts?

[Harry Terkelsen, 2016/09/29 21:16:21]

Good idea. I moved these to graph_builder

+  }
+
+  @override
   void visitConditionalExpression(ir.ConditionalExpression conditional) {
     SsaBranchBuilder brancher = new SsaBranchBuilder(this, compiler);
     brancher.handleConditional(
         () => conditional.condition.accept(this),
         () => conditional.then.accept(this),
         () => conditional.otherwise.accept(this));
   }
 
   @override
   void visitLogicalExpression(ir.LogicalExpression logicalExpression) {
@@ skipping 353 matching lines @@
     push(new HNot(popBoolified(), backend.boolType));
   }
 
   @override
   void visitStringConcatenation(ir.StringConcatenation stringConcat) {
     KernelStringBuilder stringBuilder = new KernelStringBuilder(this);
     stringConcat.accept(stringBuilder);
     stack.add(stringBuilder.result);
   }
 }