Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2380513002: Revert r403630 which broke parsing on some sites. (Closed)

Created:
4 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert r403630 which broke parsing on some sites. HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 tried to bring them closer together, but this regressed some existing sites. This should be relanded but it needs to make the parser and simulator more reliably consistent. BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2366203006 Cr-Commit-Position: refs/heads/master@{#421177} (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -177 lines) Patch
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 4 chunks +8 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 3 chunks +23 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
dominicc (has gone to gerrit)
Committed patchset #1 (id:1) manually as 5b2166eee42a2936e0653929afb2595d614288fb.
4 years, 2 months ago (2016-09-28 02:29:58 UTC) #2
jwd
4 years, 2 months ago (2016-09-28 19:37:48 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2382523002/ by jwd@chromium.org.

The reason for reverting is: BUILD.gn change missing from this merge, causing
breakage on the Beta builders
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/p...

ERROR at //testing/test.gni:271:5: Source file not found.
    executable(target_name) {
    ^------------------------
The target:
  //third_party/WebKit/Source/web:webkit_unit_tests
has a source file:
  //third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp.

Powered by Google App Engine
This is Rietveld 408576698