Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2380503002: Revert of Storage of ComputedStyle separate from LayoutObject. (Closed)

Created:
4 years, 2 months ago by Bugs Nash
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, nainar, rwlbuis, rune, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Storage of ComputedStyle separate from LayoutObject. (patchset #14 id:320001 of https://codereview.chromium.org/1962953002/ ) Reason for revert: Squad project needs redesign, no longer will use ComputedStyle on Node's data union Original issue's description: > Storage of ComputedStyle separate from LayoutObject. > > Part of stage 1 in separation of style resolution and > layout tree construction > Design doc: bit.ly/24nQ9UQ > > Changes the Node::m_data DataUnion to now allow a ComputedStyle. > > Updates Node flags with new flag HasLayoutObject to indicate whether > the DataUnion is a LayoutObject or a ComputedStyle. Adds new > hasLayoutObject method to check flag. > > Updates ComputedStyle and Layoutobject getters and setters accordingly. > > Written with nainar@ > > Originally landed as: > https://crrev.com/11af5b8769875ef50b16cb94d7eb758def0d9b08 > but was reverted. > > BUG=595137 > > Committed: https://crrev.com/7f405ec2b6914d482d081d2cb5d80bdf5226bd57 > Cr-Commit-Position: refs/heads/master@{#411933} TBR=esprehn@chromium.org,timloh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595137 Committed: https://crrev.com/a818ae856981327097e4d353ed604c9a1d822025 Cr-Commit-Position: refs/heads/master@{#421441}

Patch Set 1 #

Patch Set 2 : Fixed conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 4 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeComputedStyle.h View 1 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Bugs Nash
Created Revert of Storage of ComputedStyle separate from LayoutObject.
4 years, 2 months ago (2016-09-28 02:12:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380503002/1
4 years, 2 months ago (2016-09-28 02:12:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-28 02:12:27 UTC) #5
esprehn
lgtm
4 years, 2 months ago (2016-09-28 02:24:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380503002/150001
4 years, 2 months ago (2016-09-28 02:25:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:150001)
4 years, 2 months ago (2016-09-28 03:56:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 03:58:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a818ae856981327097e4d353ed604c9a1d822025
Cr-Commit-Position: refs/heads/master@{#421441}

Powered by Google App Engine
This is Rietveld 408576698