Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2380403003: Lazy deopt without code patching. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Lazy deopt without code patching. Keep a side table that maps a fp back to a deopt pc. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/6cff17c59aa62191b95cf95ae3f03befedea5b0b

Patch Set 1 #

Patch Set 2 : prints #

Patch Set 3 : remove tracing register assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -446 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/code_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 6 chunks +65 lines, -19 lines 0 comments Download
M runtime/vm/code_patcher.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/code_patcher_arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/code_patcher_dbc.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/code_patcher_ia32.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M runtime/vm/code_patcher_mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/code_patcher_x64.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 3 chunks +26 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/instructions_arm.h View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/instructions_arm.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M runtime/vm/instructions_arm64.h View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/instructions_arm64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/instructions_dbc.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/instructions_dbc.cc View 2 chunks +1 line, -13 lines 0 comments Download
M runtime/vm/instructions_mips.h View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/instructions_mips.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M runtime/vm/instructions_x64.h View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/instructions_x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 4 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stack_frame.h View 2 chunks +15 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 2 months ago (2016-09-30 20:41:59 UTC) #3
Florian Schneider
LGTM
4 years, 2 months ago (2016-09-30 22:08:01 UTC) #4
rmacnak
4 years, 2 months ago (2016-09-30 23:53:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6cff17c59aa62191b95cf95ae3f03befedea5b0b.

Powered by Google App Engine
This is Rietveld 408576698