Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: runtime/vm/code_patcher_arm.cc

Issue 2380403003: Lazy deopt without code patching. (Closed)
Patch Set: remove tracing register assignment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_patcher.h ('k') | runtime/vm/code_patcher_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 9
10 #include "vm/flow_graph_compiler.h" 10 #include "vm/flow_graph_compiler.h"
(...skipping 12 matching lines...) Expand all
23 23
24 void CodePatcher::PatchStaticCallAt(uword return_address, 24 void CodePatcher::PatchStaticCallAt(uword return_address,
25 const Code& code, 25 const Code& code,
26 const Code& new_target) { 26 const Code& new_target) {
27 ASSERT(code.ContainsInstructionAt(return_address)); 27 ASSERT(code.ContainsInstructionAt(return_address));
28 CallPattern call(return_address, code); 28 CallPattern call(return_address, code);
29 call.SetTargetCode(new_target); 29 call.SetTargetCode(new_target);
30 } 30 }
31 31
32 32
33 void CodePatcher::InsertDeoptimizationCallAt(uword start, uword target) { 33 void CodePatcher::InsertDeoptimizationCallAt(uword start) {
34 // The inserted call should not overlap the lazy deopt jump code. 34 UNREACHABLE();
35 ASSERT(start + CallPattern::DeoptCallPatternLengthInBytes() <= target);
36 CallPattern::InsertDeoptCallAt(start, target);
37 } 35 }
38 36
39 37
40 RawCode* CodePatcher::GetInstanceCallAt(uword return_address, 38 RawCode* CodePatcher::GetInstanceCallAt(uword return_address,
41 const Code& code, 39 const Code& code,
42 ICData* ic_data) { 40 ICData* ic_data) {
43 ASSERT(code.ContainsInstructionAt(return_address)); 41 ASSERT(code.ContainsInstructionAt(return_address));
44 CallPattern call(return_address, code); 42 CallPattern call(return_address, code);
45 if (ic_data != NULL) { 43 if (ic_data != NULL) {
46 *ic_data = call.IcData(); 44 *ic_data = call.IcData();
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 NativeFunction* target) { 110 NativeFunction* target) {
113 ASSERT(code.ContainsInstructionAt(return_address)); 111 ASSERT(code.ContainsInstructionAt(return_address));
114 NativeCallPattern call(return_address, code); 112 NativeCallPattern call(return_address, code);
115 *target = call.native_function(); 113 *target = call.native_function();
116 return call.target(); 114 return call.target();
117 } 115 }
118 116
119 } // namespace dart 117 } // namespace dart
120 118
121 #endif // defined TARGET_ARCH_ARM 119 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/code_patcher.h ('k') | runtime/vm/code_patcher_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698