Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2380233002: Changed EListStylePosition to an enum class and renamed its members to keywords (Closed)

Created:
4 years, 2 months ago by sashab
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed EListStylePosition to an enum class and renamed its members to keywords Changed EListStylePosition to an enum class and gave it an unsigned underlying type so it can be stored in a bitfield in the future. Also renamed its members to match its keywords from CSSValueKeywords.in. This is pre-work to move EListStylePosition to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/063379e6b1aa01de3f305c5343925d9d926e8cd0 Cr-Commit-Position: refs/heads/master@{#423038}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sashab
4 years, 2 months ago (2016-09-30 04:05:36 UTC) #2
meade_UTC10
lgtm
4 years, 2 months ago (2016-09-30 05:58:05 UTC) #3
rune
lgtm
4 years, 2 months ago (2016-09-30 09:52:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380233002/20001
4 years, 2 months ago (2016-10-04 23:52:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 01:26:58 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 01:28:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/063379e6b1aa01de3f305c5343925d9d926e8cd0
Cr-Commit-Position: refs/heads/master@{#423038}

Powered by Google App Engine
This is Rietveld 408576698