Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2380233002: Changed EListStylePosition to an enum class and renamed its members to keywords (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutListMarker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
5 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 5 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * Redistribution and use in source and binary forms, with or without 8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions 9 * modification, are permitted provided that the following conditions
10 * are met: 10 * are met:
(...skipping 1407 matching lines...) Expand 10 before | Expand all | Expand 10 after
1418 } 1418 }
1419 1419
1420 ASSERT_NOT_REACHED(); 1420 ASSERT_NOT_REACHED();
1421 return LineBreakAuto; 1421 return LineBreakAuto;
1422 } 1422 }
1423 1423
1424 template <> 1424 template <>
1425 inline CSSIdentifierValue::CSSIdentifierValue(EListStylePosition e) 1425 inline CSSIdentifierValue::CSSIdentifierValue(EListStylePosition e)
1426 : CSSValue(IdentifierClass) { 1426 : CSSValue(IdentifierClass) {
1427 switch (e) { 1427 switch (e) {
1428 case ListStylePositionOutside: 1428 case EListStylePosition::Outside:
1429 m_valueID = CSSValueOutside; 1429 m_valueID = CSSValueOutside;
1430 break; 1430 break;
1431 case ListStylePositionInside: 1431 case EListStylePosition::Inside:
1432 m_valueID = CSSValueInside; 1432 m_valueID = CSSValueInside;
1433 break; 1433 break;
1434 } 1434 }
1435 } 1435 }
1436 1436
1437 template <> 1437 template <>
1438 inline EListStylePosition CSSIdentifierValue::convertTo() const { 1438 inline EListStylePosition CSSIdentifierValue::convertTo() const {
1439 switch (m_valueID) { 1439 switch (m_valueID) {
1440 case CSSValueOutside: 1440 case CSSValueOutside:
1441 return ListStylePositionOutside; 1441 return EListStylePosition::Outside;
1442 case CSSValueInside: 1442 case CSSValueInside:
1443 return ListStylePositionInside; 1443 return EListStylePosition::Inside;
1444 default: 1444 default:
1445 break; 1445 break;
1446 } 1446 }
1447 1447
1448 ASSERT_NOT_REACHED(); 1448 ASSERT_NOT_REACHED();
1449 return ListStylePositionOutside; 1449 return EListStylePosition::Outside;
1450 } 1450 }
1451 1451
1452 template <> 1452 template <>
1453 inline CSSIdentifierValue::CSSIdentifierValue(EListStyleType e) 1453 inline CSSIdentifierValue::CSSIdentifierValue(EListStyleType e)
1454 : CSSValue(IdentifierClass) { 1454 : CSSValue(IdentifierClass) {
1455 switch (e) { 1455 switch (e) {
1456 case ArabicIndic: 1456 case ArabicIndic:
1457 m_valueID = CSSValueArabicIndic; 1457 m_valueID = CSSValueArabicIndic;
1458 break; 1458 break;
1459 case Armenian: 1459 case Armenian:
(...skipping 3070 matching lines...) Expand 10 before | Expand all | Expand 10 after
4530 default: 4530 default:
4531 break; 4531 break;
4532 } 4532 }
4533 ASSERT_NOT_REACHED(); 4533 ASSERT_NOT_REACHED();
4534 return ContainsNone; 4534 return ContainsNone;
4535 } 4535 }
4536 4536
4537 } // namespace blink 4537 } // namespace blink
4538 4538
4539 #endif 4539 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutListMarker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698