Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html

Issue 2380183002: Remove WebAudio doppler effect API surface (already no-ops) (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html b/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html
index a7712cd59e7e3795e114b982cb503257da5b4349..84ee37232dad5ff8b6ebc0954b2bb34a6d844514 100644
--- a/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html
+++ b/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html
@@ -7,15 +7,9 @@ var context = new AudioContext();
var listener = context.listener;
var panner = context.createPanner();
-shouldBe("listener.dopplerFactor", "1");
-evalAndLog("listener.dopplerFactor = 2");
-shouldBe("listener.dopplerFactor", "2");
+shouldBeUndefined("listener.dopplerFactor");
+shouldBeUndefined("listener.speedOfSound");
hongchan 2016/09/29 20:58:28 Hmm. Is this necessary?
foolip 2016/09/29 21:13:05 My view is that this kind of test isn't very valua
-shouldBe("listener.speedOfSound", "343.3");
-evalAndLog("listener.speedOfSound = 400");
-shouldBe("listener.speedOfSound", "400");
-
-evalAndLog("listener.setVelocity(0, 0, 0)");
-
-evalAndLog("panner.setVelocity(0, 0, 0)");
+shouldThrow("listener.setVelocity(0, 0, 0)");
foolip 2016/09/29 21:13:05 Checking that the method doesn't exist would be mo
+shouldThrow("panner.setVelocity(0, 0, 0)");
</script>

Powered by Google App Engine
This is Rietveld 408576698