third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html - Issue 2380183002: Remove WebAudio doppler effect API surface (already no-ops)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html

Issue 2380183002: Remove WebAudio doppler effect API surface (already no-ops) (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../resources/js-test.js"></script>	2 <script src="../resources/js-test.js"></script>

3 <script>	3 <script>

4 description("Tests doppler deprecation messages");	4 description("Tests doppler deprecation messages");

5	5

6 var context = new AudioContext();	6 var context = new AudioContext();

7 var listener = context.listener;	7 var listener = context.listener;

8 var panner = context.createPanner();	8 var panner = context.createPanner();

9	9

10 shouldBe("listener.dopplerFactor", "1");	10 shouldBeUndefined("listener.dopplerFactor");

11 evalAndLog("listener.dopplerFactor = 2");	11 shouldBeUndefined("listener.speedOfSound");
	hongchan 2016/09/29 20:58:28 Hmm. Is this necessary? Hmm. Is this necessary? foolip 2016/09/29 21:13:05 My view is that this kind of test isn't very valua Show quoted text On 2016/09/29 20:58:28, hoch wrote: > Hmm. Is this necessary? My view is that this kind of test isn't very valuable in LayoutTests, but if any other engine implemented these, then submitting it to web-platform-tests as a historical.html test can provoke others to also remove. Filing bugs of course also helps. Example: https://github.com/w3c/web-platform-tests/blob/master/dom/historical.html
12 shouldBe("listener.dopplerFactor", "2");

13	12

14 shouldBe("listener.speedOfSound", "343.3");	13 shouldThrow("listener.setVelocity(0, 0, 0)");
	foolip 2016/09/29 21:13:05 Checking that the method doesn't exist would be mo Checking that the method doesn't exist would be more clear.
15 evalAndLog("listener.speedOfSound = 400");	14 shouldThrow("panner.setVelocity(0, 0, 0)");

16 shouldBe("listener.speedOfSound", "400");

17

18 evalAndLog("listener.setVelocity(0, 0, 0)");

19

20 evalAndLog("panner.setVelocity(0, 0, 0)");

21 </script>	15 </script>

OLD	NEW