Do not register synthetic field trial before initializing TaskScheduler.

Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518
Committed: https://crrev.com/6c74f60870b45a11455e19f5d1a2330b667eb811
Cr-Commit-Position: refs/heads/master@{#422278}

[fdoray, 2016-09-29 14:37:47]

fdoray@chromium.org changed reviewers:
+ asvitkine@chromium.org, robliao@chromium.org

[fdoray, 2016-09-29 14:37:47]

PTAL

[fdoray, 2016-09-29 14:38:04]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 15:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 15:14:06]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-09-29 16:35:24]

lgtm

[fdoray, 2016-09-29 16:50:03]

fdoray@chromium.org changed reviewers:
+ brettw@chromium.org

[fdoray, 2016-09-29 16:50:03]

brettw@: PTAL
(You reviewed a related CL a few days ago
https://codereview.chromium.org/2342373002/)

[robliao, 2016-09-30 01:10:10]

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:917: tracing::SetupNavigationTracing();
This section seems like it could go outside of SetupMetrics. Is this triggering
issues?

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1529: const base::string16
pre_read_field_trial_registry_path =
Can this be done in a separate CL?

[fdoray, 2016-09-30 12:36:01]

Description was changed from

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization. It also moves code that isn't directly
related to the initialization of FieldTrialList and FeatureList out
of ChromeBrowserMainParts::SetupFieldTrials.

BUG=636518
==========

to

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518
==========

[fdoray, 2016-09-30 12:36:42]

brettw@: PTAL

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:917: tracing::SetupNavigationTracing();
On 2016/09/30 01:10:09, robliao wrote:
> This section seems like it could go outside of SetupMetrics. Is this
triggering
> issues?

No longer changing this section in this CL.

https://codereview.chromium.org/2380043002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1529: const base::string16
pre_read_field_trial_registry_path =
On 2016/09/30 01:10:09, robliao wrote:
> Can this be done in a separate CL?

Done. Made the CL smaller.

[robliao, 2016-09-30 18:10:56]

Overall looking reasonable.

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:901: const base::string16
pre_read_field_trial_registry_path =
This is intended to be in this CL or a different CL?

[fdoray, 2016-09-30 19:06:40]

robliao@: PTAnL

brettw@: PTAL

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:901: const base::string16
pre_read_field_trial_registry_path =
On 2016/09/30 18:10:56, robliao wrote:
> This is intended to be in this CL or a different CL?

I did not change this block of code in this CL. I just moved the code related to
sampling profiler.

[robliao, 2016-09-30 19:08:10]

lgtm

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2380043002/diff/40001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:901: const base::string16
pre_read_field_trial_registry_path =
On 2016/09/30 19:06:40, fdoray wrote:
> On 2016/09/30 18:10:56, robliao wrote:
> > This is intended to be in this CL or a different CL?
> 
> I did not change this block of code in this CL. I just moved the code related
to
> sampling profiler.

My mistake. I looked at the wrong diff mode!

[brettw, 2016-09-30 21:41:43]

lgtm

[fdoray, 2016-09-30 21:44:22]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-30 21:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2380043002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-30 21:44:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 02:07:33]

Description was changed from

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518
==========

to

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518
==========

[commit-bot: I haz the power, 2016-10-01 02:07:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-01 02:11:27]

Description was changed from

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518
==========

to

==========
Do not register synthetic field trial before initializing TaskScheduler.

Registering a synthetic field trial initializes the MetricsService.
Initializing the MetricsService posts a task to the blocking pool.
It is not possible to post a task to the blocking pool before
TaskScheduler initialization when the blocking pool is redirected to
TaskScheduler.

This CL moves the registration of the
SyntheticStackProfilingConfiguration synthetic field trial after
TaskScheduler initialization.

BUG=636518

Committed: https://crrev.com/6c74f60870b45a11455e19f5d1a2330b667eb811
Cr-Commit-Position: refs/heads/master@{#422278}
==========

[commit-bot: I haz the power, 2016-10-01 02:11:28]

Patchset 3 (id:??) landed as
https://crrev.com/6c74f60870b45a11455e19f5d1a2330b667eb811
Cr-Commit-Position: refs/heads/master@{#422278}