|
|
DescriptionAdd BrowserScheduler field trial to testing config for desktop.
With this CL, redirection of the SequencedWorkerPool to the
TaskScheduler will be tested on bots.
BUG=553459
Committed: https://crrev.com/af3dcd65393eca7f9164c8ace687f1fb0dc458bb
Cr-Commit-Position: refs/heads/master@{#425356}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Patch Set 5 : rebase #Patch Set 6 : rebase #Patch Set 7 : rebase #Patch Set 8 : rebase #Patch Set 9 : rebase #Patch Set 10 : rebase #Patch Set 11 : rebase #Messages
Total messages: 44 (33 generated)
fdoray@chromium.org changed reviewers: + rkaplow@chromium.org
PTAL
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/09/20 17:56:06, rkaplow wrote: > lgtm FYI, the combined format landed. Let me know if you want to merge this or I can. I plan on making this one of the practical examples of how to add an experiment :-).
Description was changed from ========== Add BrowserScheduler field trial to desktop testing configs. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 ========== to ========== Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 ==========
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/21 20:47:43, robliao wrote: > On 2016/09/20 17:56:06, rkaplow wrote: > > lgtm > > FYI, the combined format landed. Let me know if you want to merge this or I can. > I plan on making this one of the practical examples of how to add an experiment > :-). I updated the CL to use the combined format. PTAnL.
On 2016/09/22 19:14:15, fdoray wrote: > On 2016/09/21 20:47:43, robliao wrote: > > On 2016/09/20 17:56:06, rkaplow wrote: > > > lgtm > > > > FYI, the combined format landed. Let me know if you want to merge this or I > can. > > I plan on making this one of the practical examples of how to add an > experiment > > :-). > > I updated the CL to use the combined format. PTAnL. Woot LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org, gab@chromium.org Link to the patchset: https://codereview.chromium.org/2353973002/#ps160001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2353973002/#ps200001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 ========== to ========== Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 ==========
Message was sent while issue was closed.
Committed patchset #11 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 ========== to ========== Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 Committed: https://crrev.com/af3dcd65393eca7f9164c8ace687f1fb0dc458bb Cr-Commit-Position: refs/heads/master@{#425356} ==========
Message was sent while issue was closed.
Patchset 11 (id:??) landed as https://crrev.com/af3dcd65393eca7f9164c8ace687f1fb0dc458bb Cr-Commit-Position: refs/heads/master@{#425356}
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/2430733002/ by fdoray@chromium.org. The reason for reverting is: https://crbug.com/656629 Power regression. |