Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2353973002: Add BrowserScheduler field trial to testing config for desktop. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
gab, rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BrowserScheduler field trial to testing config for desktop. With this CL, redirection of the SequencedWorkerPool to the TaskScheduler will be tested on bots. BUG=553459 Committed: https://crrev.com/af3dcd65393eca7f9164c8ace687f1fb0dc458bb Cr-Commit-Position: refs/heads/master@{#425356}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : rebase #

Patch Set 11 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 44 (33 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-20 15:38:51 UTC) #2
rkaplow
lgtm
4 years, 3 months ago (2016-09-20 17:56:06 UTC) #5
robliao
On 2016/09/20 17:56:06, rkaplow wrote: > lgtm FYI, the combined format landed. Let me know ...
4 years, 3 months ago (2016-09-21 20:47:43 UTC) #8
fdoray
On 2016/09/21 20:47:43, robliao wrote: > On 2016/09/20 17:56:06, rkaplow wrote: > > lgtm > ...
4 years, 3 months ago (2016-09-22 19:14:15 UTC) #12
gab
On 2016/09/22 19:14:15, fdoray wrote: > On 2016/09/21 20:47:43, robliao wrote: > > On 2016/09/20 ...
4 years, 3 months ago (2016-09-22 19:25:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353973002/160001
4 years, 2 months ago (2016-10-04 16:00:50 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/309603)
4 years, 2 months ago (2016-10-04 16:50:47 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353973002/200001
4 years, 2 months ago (2016-10-14 14:54:36 UTC) #39
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 2 months ago (2016-10-14 16:45:16 UTC) #41
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/af3dcd65393eca7f9164c8ace687f1fb0dc458bb Cr-Commit-Position: refs/heads/master@{#425356}
4 years, 2 months ago (2016-10-14 16:47:31 UTC) #43
fdoray
4 years, 2 months ago (2016-10-18 15:31:44 UTC) #44
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2430733002/ by fdoray@chromium.org.

The reason for reverting is: https://crbug.com/656629 Power regression.

Powered by Google App Engine
This is Rietveld 408576698