DescriptionGCM Store: Fix invalid argument errors
Opening the GCM leveldb database resulted in a high rate of "does not
exist (create_if_missing is false)" invalid argument errors, since the
GCM Store was incorrectly considering the database to already exist if
its directory exists, when actually the directory sometimes continues
to exist after the database is destroyed.
This is expected to significantly reduce the following UMA buckets:
- GCM.Database.Open "Invalid Argument" percent (from ~20% to < 1%)
- GCM.LoadStatus "Store open failed" percent (from ~10% to < 1%)
- GCM.ResetStore "Infinite store reset" count (from ~10% of GCM.Database.Open
count to < 1%)
BUG=650254
Committed: https://crrev.com/6d6c7809c0fff72b92a8038b7d65909b7449d3da
Cr-Commit-Position: refs/heads/master@{#421957}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address review comments #Patch Set 3 : Fix Win compile with FILE_PATH_LITERAL #
Messages
Total messages: 18 (9 generated)
|