chrome/browser/android/banners/app_banner_infobar_delegate_android.cc - Issue 2379923002: Implement "appinstalled" event on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)

Patch Set: Respond to review / fix compile. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('K') | « chrome/browser/DEPS ('k') | chrome/browser/android/webapps/add_to_homescreen_manager.h » ('j') | third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

index 0007725bafa44a38026c79b5482061aa16482c1f..222f6b282576185937cc6e3a9844e2cc72a280d3 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

@@ -358,8 +358,10 @@ bool AppBannerInfoBarDelegateAndroid::TriggeredFromBanner() const {

}

void AppBannerInfoBarDelegateAndroid::SendBannerAccepted() {

- if (weak_manager_ && TriggeredFromBanner())

+ if (weak_manager_ && TriggeredFromBanner()) {

weak_manager_->SendBannerAccepted(event_request_id_);

dominickn 2016/12/12 05:03:30 You need if (!is_webapk_) to stop this triggering

Matt Giuca 2016/12/14 03:39:40 Done.

+ weak_manager_->OnInstall();

+ }

}

void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished(