Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)
Patch Set: Respond to review / fix compile. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 8c04ebb87fcb7afba65a75fc4b86a598662da12f..c93362bebe3671e1cea4ec720e9a9a7b23f74d70 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -30,9 +30,11 @@ import org.chromium.chrome.browser.infobar.AppBannerInfoBarDelegateAndroid;
import org.chromium.chrome.browser.infobar.InfoBar;
import org.chromium.chrome.browser.infobar.InfoBarContainer;
import org.chromium.chrome.browser.infobar.InfoBarContainer.InfoBarAnimationListener;
+import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.webapps.WebappDataStorage;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
import org.chromium.chrome.test.util.browser.TabLoadObserver;
+import org.chromium.chrome.test.util.browser.TabTitleObserver;
import org.chromium.chrome.test.util.browser.WebappTestPage;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -497,6 +499,17 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@SmallTest
@Feature({"AppBanners"})
@RetryOnFailure
+ public void testAppInstalledEvent() throws Exception {
+ triggerWebAppBanner(mWebAppUrl, WEB_APP_TITLE, true);
+
+ // The appinstalled event should fire (and cause the title to change).
+ Tab tab = getActivity().getActivityTab();
+ new TabTitleObserver(tab, "Got appinstalled").waitForTitleUpdate(3);
+ }
+
+ @SmallTest
+ @Feature({"AppBanners"})
+ @RetryOnFailure
dominickn 2016/12/12 05:03:30 Nit: remove RetryOnFailure (I have a CL up that re
Matt Giuca 2016/12/14 03:39:40 Done.
public void testWebAppSplashscreenIsDownloaded() throws Exception {
// Sets the overriden factory to observer splash screen update.
final TestDataStorageFactory dataStorageFactory = new TestDataStorageFactory();

Powered by Google App Engine
This is Rietveld 408576698