Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 23799004: gm: add self-test to confirm that ignore-failure field is respected (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, bsalomon
Visibility:
Public.

Description

gm: add self-test to confirm that ignore-failure field is respected BUG=skia:1578 R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11047

Patch Set 1 #

Total comments: 1

Patch Set 2 : ignore_one_failure #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gm/gmmain.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt View 1 2 chunks +4 lines, -3 lines 1 comment Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/mismatchPath/565/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/mismatchPath/565/selftest1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/mismatchPath/8888/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/mismatchPath/8888/selftest1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/mismatchPath/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/missingExpectationsPath/565/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/missingExpectationsPath/8888/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/missingExpectationsPath/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/return_value View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/stdout View 1 chunk +4 lines, -4 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/writePath/565/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/writePath/565/selftest1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/writePath/8888/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/writePath/8888/selftest1.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/tests/outputs/ignoring-some-failures/output-expected/writePath/bogusfile View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/run.sh View 1 3 chunks +14 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
epoger
https://codereview.chromium.org/23799004/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.chromium.org/23799004/diff/1/gm/tests/run.sh#newcode166 gm/tests/run.sh:166: # TODO: for now, this just copies in the ...
7 years, 3 months ago (2013-08-30 19:32:03 UTC) #1
epoger
Ready for review. https://codereview.chromium.org/23799004/diff/5001/gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt File gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt (right): https://codereview.chromium.org/23799004/diff/5001/gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt#newcode7 gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt:7: "565/selftest1.png" : [ "bitmap-64bitMD5", 12927999507540085554 ] ...
7 years, 3 months ago (2013-08-30 19:53:01 UTC) #2
scroggo
lgtm
7 years, 3 months ago (2013-08-30 20:01:24 UTC) #3
epoger
7 years, 3 months ago (2013-08-30 20:19:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698