Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gm/gmmain.cpp

Issue 23799004: gm: add self-test to confirm that ignore-failure field is respected (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: ignore_one_failure Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/tests/outputs/ignoring-some-failures/output-expected/command_line » ('j') | gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gmmain.cpp
===================================================================
--- gm/gmmain.cpp (revision 11031)
+++ gm/gmmain.cpp (working copy)
@@ -821,12 +821,6 @@
this->fJsonActualResults_Succeeded[testName] = jsonActualResults;
} else {
if (ignoreFailure) {
- // TODO: Once we have added the ability to compare
- // actual results against expectations in a JSON file
- // (where we can set ignore-failure to either true or
- // false), add test cases that exercise ignored
- // failures (both for kMissingExpectations_ErrorType
- // and kExpectationsMismatch_ErrorType).
this->fJsonActualResults_FailureIgnored[testName] =
jsonActualResults;
} else {
« no previous file with comments | « no previous file | gm/tests/outputs/ignoring-some-failures/output-expected/command_line » ('j') | gm/tests/outputs/ignoring-some-failures/output-expected/json-summary.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698