Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/app_list/views/search_result_list_view_unittest.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/app_list_view_unittest.cc ('k') | ui/app_list/views/search_result_page_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/search_result_list_view_unittest.cc
diff --git a/ui/app_list/views/search_result_list_view_unittest.cc b/ui/app_list/views/search_result_list_view_unittest.cc
index 0e3178e6afaa69fbb6c15ab84ea2f64db07341cd..e3bd06b384514284f4010befa00b39981688ffba 100644
--- a/ui/app_list/views/search_result_list_view_unittest.cc
+++ b/ui/app_list/views/search_result_list_view_unittest.cc
@@ -9,6 +9,7 @@
#include <map>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/app_list/app_list_model.h"
@@ -62,12 +63,13 @@ class SearchResultListViewTest : public views::ViewsTestBase,
void SetUpSearchResults() {
AppListModel::SearchResults* results = GetResults();
for (int i = 0; i < kDefaultSearchItems; ++i) {
- TestSearchResult* result = new TestSearchResult();
+ std::unique_ptr<TestSearchResult> result =
+ base::MakeUnique<TestSearchResult>();
result->set_display_type(SearchResult::DISPLAY_LIST);
result->set_title(base::UTF8ToUTF16(base::StringPrintf("Result %d", i)));
if (i < 2)
result->set_details(base::ASCIIToUTF16("Detail"));
- results->Add(result);
+ results->Add(std::move(result));
}
// Adding results will schedule Update().
@@ -90,7 +92,7 @@ class SearchResultListViewTest : public views::ViewsTestBase,
}
void AddTestResultAtIndex(int index) {
- GetResults()->Add(new TestSearchResult());
+ GetResults()->Add(base::MakeUnique<TestSearchResult>());
}
void DeleteResultAt(int index) { GetResults()->DeleteAt(index); }
« no previous file with comments | « ui/app_list/views/app_list_view_unittest.cc ('k') | ui/app_list/views/search_result_page_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698