Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: ui/app_list/views/app_list_view_unittest.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/search/mixer.cc ('k') | ui/app_list/views/search_result_list_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/app_list_view_unittest.cc
diff --git a/ui/app_list/views/app_list_view_unittest.cc b/ui/app_list/views/app_list_view_unittest.cc
index ba3519f6fa7ebbd924ee579d4d0d50d242d90c77..97f8f3c2465f08e0cb33a085ae25c6e17470a334 100644
--- a/ui/app_list/views/app_list_view_unittest.cc
+++ b/ui/app_list/views/app_list_view_unittest.cc
@@ -414,7 +414,7 @@ void AppListViewTestContext::RunStartPageTest() {
// Check tiles hide and show on deletion and addition.
EXPECT_TRUE(SetAppListState(AppListModel::STATE_START));
- model->results()->Add(new TestStartPageSearchResult());
+ model->results()->Add(base::MakeUnique<TestStartPageSearchResult>());
start_page_view->UpdateForTesting();
EXPECT_EQ(1u, GetVisibleViews(start_page_view->tile_views()));
model->results()->DeleteAll();
@@ -424,7 +424,7 @@ void AppListViewTestContext::RunStartPageTest() {
// Tiles should not update when the start page is not active but should be
// correct once the start page is shown.
EXPECT_TRUE(SetAppListState(AppListModel::STATE_APPS));
- model->results()->Add(new TestStartPageSearchResult());
+ model->results()->Add(base::MakeUnique<TestStartPageSearchResult>());
start_page_view->UpdateForTesting();
EXPECT_EQ(0u, GetVisibleViews(start_page_view->tile_views()));
EXPECT_TRUE(SetAppListState(AppListModel::STATE_START));
@@ -488,13 +488,16 @@ void AppListViewTestContext::RunProfileChangeTest() {
EXPECT_NO_FATAL_FAILURE(CheckView(start_page_view));
// New model updates should be processed by the start page view.
- delegate_->GetTestModel()->results()->Add(new TestStartPageSearchResult());
+ delegate_->GetTestModel()->results()->Add(
+ base::MakeUnique<TestStartPageSearchResult>());
start_page_view->UpdateForTesting();
EXPECT_EQ(1u, GetVisibleViews(start_page_view->tile_views()));
// Old model updates should be ignored.
- original_test_model->results()->Add(new TestStartPageSearchResult());
- original_test_model->results()->Add(new TestStartPageSearchResult());
+ original_test_model->results()->Add(
+ base::MakeUnique<TestStartPageSearchResult>());
+ original_test_model->results()->Add(
+ base::MakeUnique<TestStartPageSearchResult>());
start_page_view->UpdateForTesting();
EXPECT_EQ(1u, GetVisibleViews(start_page_view->tile_views()));
« no previous file with comments | « ui/app_list/search/mixer.cc ('k') | ui/app_list/views/search_result_list_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698