third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp - Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('K') | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/public/BUILD.gn » ('j') | third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebPresentationController.cpp b/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

similarity index 65%

copy from third_party/WebKit/Source/platform/exported/WebPresentationController.cpp

copy to third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

index e71aecff6ffca034c4c7cd360c3184d9a227be6a..c50a9d6f66a5a2b277449c09b275eb033e820ba0 100644

--- a/third_party/WebKit/Source/platform/exported/WebPresentationController.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

@@ -1,11 +1,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "public/platform/modules/presentation/WebPresentationController.h"

+#include "public/platform/modules/presentation/WebPresentationConnection.h"

-// This WebPresentationController.cpp, which includes only

-// WebPresentationController.h, should be in Source/platform/exported,

+// This WebPresentationConnection.cpp, which includes only

+// WebPresentationConnection.h, should be in Source/platform/exported,

// because WebPresentationController is not compiled without this cpp.

// So if we don't have this cpp, we will see unresolved symbol error

// when constructor/destructor's address is required.