third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp - Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "public/platform/modules/presentation/WebPresentationController.h"	5 #include "public/platform/modules/presentation/WebPresentationConnection.h"

6	6

7 // This WebPresentationController.cpp, which includes only	7 // This WebPresentationConnection.cpp, which includes only

8 // WebPresentationController.h, should be in Source/platform/exported,	8 // WebPresentationConnection.h, should be in Source/platform/exported,

9 // because WebPresentationController is not compiled without this cpp.	9 // because WebPresentationController is not compiled without this cpp.

10 // So if we don't have this cpp, we will see unresolved symbol error	10 // So if we don't have this cpp, we will see unresolved symbol error

11 // when constructor/destructor's address is required.	11 // when constructor/destructor's address is required.

OLD	NEW