Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2866)

Unified Diff: content/renderer/presentation/presentation_connection_client.h

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_connection_client.h
diff --git a/content/renderer/presentation/presentation_connection_client.h b/content/renderer/presentation/presentation_connection_client.h
index f8e0bac00034b04684557338fcb418b5edb9c314..799ad62ec1a3533a49f434b22571a14bff0338d8 100644
--- a/content/renderer/presentation/presentation_connection_client.h
+++ b/content/renderer/presentation/presentation_connection_client.h
@@ -7,6 +7,7 @@
#include "base/compiler_specific.h"
#include "content/common/content_export.h"
+#include "content/renderer/presentation/renderer_presentation_connection.h"
#include "third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionClient.h"
#include "third_party/WebKit/public/platform/modules/presentation/presentation.mojom.h"
#include "url/gurl.h"
@@ -22,15 +23,20 @@ class CONTENT_EXPORT PresentationConnectionClient
blink::mojom::PresentationSessionInfoPtr session_info);
explicit PresentationConnectionClient(const GURL& url,
const mojo::String& id);
+ explicit PresentationConnectionClient(
mark a. foltz 2016/10/08 00:33:42 No need for explicit on 2-argument ctor
imcheng 2016/10/12 02:22:54 Could you also please document what the different
zhaobin 2016/10/12 02:27:33 Done.
zhaobin 2016/10/13 02:33:52 Done.
+ blink::mojom::PresentationSessionInfoPtr session_info,
+ blink::WebPresentationConnectionProxy* proxy);
~PresentationConnectionClient() override;
// WebPresentationConnectionClient implementation.
blink::WebURL getUrl() override;
blink::WebString getId() override;
+ blink::WebPresentationConnectionProxy* getOrCreateProxy() override;
private:
blink::WebURL url_;
blink::WebString id_;
+ blink::WebPresentationConnectionProxy* proxy_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698