Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: content/renderer/presentation/presentation_connection_client.h

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_ 5 #ifndef CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_
6 #define CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_ 6 #define CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/renderer/presentation/renderer_presentation_connection.h"
10 #include "third_party/WebKit/public/platform/modules/presentation/WebPresentatio nConnectionClient.h" 11 #include "third_party/WebKit/public/platform/modules/presentation/WebPresentatio nConnectionClient.h"
11 #include "third_party/WebKit/public/platform/modules/presentation/presentation.m ojom.h" 12 #include "third_party/WebKit/public/platform/modules/presentation/presentation.m ojom.h"
12 #include "url/gurl.h" 13 #include "url/gurl.h"
13 14
14 namespace content { 15 namespace content {
15 16
16 // PresentationConnectionClient is passed to the Blink layer if presentation 17 // PresentationConnectionClient is passed to the Blink layer if presentation
17 // session has been created successfully. Owned by the callback. 18 // session has been created successfully. Owned by the callback.
18 class CONTENT_EXPORT PresentationConnectionClient 19 class CONTENT_EXPORT PresentationConnectionClient
19 : public NON_EXPORTED_BASE(blink::WebPresentationConnectionClient) { 20 : public NON_EXPORTED_BASE(blink::WebPresentationConnectionClient) {
20 public: 21 public:
21 explicit PresentationConnectionClient( 22 explicit PresentationConnectionClient(
22 blink::mojom::PresentationSessionInfoPtr session_info); 23 blink::mojom::PresentationSessionInfoPtr session_info);
23 explicit PresentationConnectionClient(const GURL& url, 24 explicit PresentationConnectionClient(const GURL& url,
24 const mojo::String& id); 25 const mojo::String& id);
26 explicit PresentationConnectionClient(
mark a. foltz 2016/10/08 00:33:42 No need for explicit on 2-argument ctor
imcheng 2016/10/12 02:22:54 Could you also please document what the different
zhaobin 2016/10/12 02:27:33 Done.
zhaobin 2016/10/13 02:33:52 Done.
27 blink::mojom::PresentationSessionInfoPtr session_info,
28 blink::WebPresentationConnectionProxy* proxy);
25 ~PresentationConnectionClient() override; 29 ~PresentationConnectionClient() override;
26 30
27 // WebPresentationConnectionClient implementation. 31 // WebPresentationConnectionClient implementation.
28 blink::WebURL getUrl() override; 32 blink::WebURL getUrl() override;
29 blink::WebString getId() override; 33 blink::WebString getId() override;
34 blink::WebPresentationConnectionProxy* getOrCreateProxy() override;
30 35
31 private: 36 private:
32 blink::WebURL url_; 37 blink::WebURL url_;
33 blink::WebString id_; 38 blink::WebString id_;
39 blink::WebPresentationConnectionProxy* proxy_;
34 }; 40 };
35 41
36 } // namespace content 42 } // namespace content
37 43
38 #endif // CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_ 44 #endif // CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698