[Presentation API] (alternative) 1-UA: send message between controller and receiver page

content/renderer/presentation/presentation_connection_client.h

Index: content/renderer/presentation/presentation_connection_client.h
diff --git a/content/renderer/presentation/presentation_connection_client.h b/content/renderer/presentation/presentation_connection_client.h
index f8e0bac00034b04684557338fcb418b5edb9c314..7713e129b99b8dde5f72e5f8b949d0d4c8f811fd 100644
--- a/content/renderer/presentation/presentation_connection_client.h
+++ b/content/renderer/presentation/presentation_connection_client.h
@@ -20,17 +20,28 @@ class CONTENT_EXPORT PresentationConnectionClient
  public:
   explicit PresentationConnectionClient(
       blink::mojom::PresentationSessionInfoPtr session_info);
-  explicit PresentationConnectionClient(const GURL& url,
-                                        const mojo::String& id);
+  PresentationConnectionClient(const GURL& url, const mojo::String& id);

[imcheng, 2016/11/01 17:20:30]

do we actually still need this? This is only called in
PresentationDispatcher::OnSessionMessagesReceived, and in there we already have
a blink::mojom::PresentationSessionInfoPtr.

[zhaobin, 2016/11/02 03:55:48]

Done.

+  // Call this constructor to create PresentationConnectionClient for

[imcheng, 2016/11/01 17:20:30]

I would word this as: Creates a PresentationConnectionClient for a 1-UA
presentation.

[imcheng, 2016/11/01 17:20:30]

nit: add extra line above comments

[zhaobin, 2016/11/02 03:55:47]

Done.

[zhaobin, 2016/11/02 03:55:47]

Done.

+  // 1-UA presentation.
+  // |session_info|: contains presentation ID and URL info
+  // |proxy|: Proxy to blink PresentationConnection object in current render
+  //          process. Ownership is passed to this class.
+  PresentationConnectionClient(
+      blink::mojom::PresentationSessionInfoPtr session_info,
+      std::unique_ptr<blink::WebPresentationConnectionProxy> proxy);
   ~PresentationConnectionClient() override;
 
   // WebPresentationConnectionClient implementation.
   blink::WebURL getUrl() override;
   blink::WebString getId() override;
+  // Returns proxy passed into this class. It will transfer ownership of

[imcheng, 2016/11/01 17:20:30]

nit: add extra line above comments

[zhaobin, 2016/11/02 03:55:48]

Done.

+  // |proxy_| to calling object (PresentationConnection).
+  std::unique_ptr<blink::WebPresentationConnectionProxy> takeProxy() override;
 
  private:
   blink::WebURL url_;
   blink::WebString id_;
+  std::unique_ptr<blink::WebPresentationConnectionProxy> proxy_;
 };
 
 }  // namespace content