[Presentation API] (alternative) 1-UA: send message between controller and receiver page

content/renderer/presentation/presentation_connection_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_
 #define CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_
 
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
 #include "third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionClient.h"
 #include "third_party/WebKit/public/platform/modules/presentation/presentation.mojom.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // PresentationConnectionClient is passed to the Blink layer if presentation
 // session has been created successfully. Owned by the callback.
 class CONTENT_EXPORT PresentationConnectionClient
     : public NON_EXPORTED_BASE(blink::WebPresentationConnectionClient) {
  public:
   explicit PresentationConnectionClient(
       blink::mojom::PresentationSessionInfoPtr session_info);
-  explicit PresentationConnectionClient(const GURL& url,
-                                        const mojo::String& id);
+  PresentationConnectionClient(const GURL& url, const mojo::String& id);

[imcheng, 2016/11/01 17:20:30]

do we actually still need this? This is only called in
PresentationDispatcher::OnSessionMessagesReceived, and in there we already have
a blink::mojom::PresentationSessionInfoPtr.

[zhaobin, 2016/11/02 03:55:48]

Done.

+  // Call this constructor to create PresentationConnectionClient for

[imcheng, 2016/11/01 17:20:30]

I would word this as: Creates a PresentationConnectionClient for a 1-UA
presentation.

[imcheng, 2016/11/01 17:20:30]

nit: add extra line above comments

[zhaobin, 2016/11/02 03:55:47]

Done.

[zhaobin, 2016/11/02 03:55:47]

Done.

+  // 1-UA presentation.
+  // |session_info|: contains presentation ID and URL info
+  // |proxy|: Proxy to blink PresentationConnection object in current render
+  //          process. Ownership is passed to this class.
+  PresentationConnectionClient(
+      blink::mojom::PresentationSessionInfoPtr session_info,
+      std::unique_ptr<blink::WebPresentationConnectionProxy> proxy);
   ~PresentationConnectionClient() override;
 
   // WebPresentationConnectionClient implementation.
   blink::WebURL getUrl() override;
   blink::WebString getId() override;
+  // Returns proxy passed into this class. It will transfer ownership of

[imcheng, 2016/11/01 17:20:30]

nit: add extra line above comments

[zhaobin, 2016/11/02 03:55:48]

Done.

+  // |proxy_| to calling object (PresentationConnection).
+  std::unique_ptr<blink::WebPresentationConnectionProxy> takeProxy() override;
 
  private:
   blink::WebURL url_;
   blink::WebString id_;
+  std::unique_ptr<blink::WebPresentationConnectionProxy> proxy_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PRESENTATION_PRESENTATION_SESSION_CLIENT_H_