Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: content/public/browser/presentation_session.cc

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/presentation_session.cc
diff --git a/content/public/browser/presentation_session.cc b/content/public/browser/presentation_session.cc
index ceca42d9f895fd37093852e491022a92650c13af..6dce417e040a3fd1c941fa0fbd7bc69a5e6ba3de 100644
--- a/content/public/browser/presentation_session.cc
+++ b/content/public/browser/presentation_session.cc
@@ -9,7 +9,17 @@ namespace content {
PresentationSessionInfo::PresentationSessionInfo(
const GURL& presentation_url,
const std::string& presentation_id)
- : presentation_url(presentation_url), presentation_id(presentation_id) {}
+ : presentation_url(presentation_url),
imcheng 2016/11/01 17:20:29 nit: Use the delegated constructor pattern: Presen
zhaobin 2016/11/02 03:55:47 Done.
+ presentation_id(presentation_id),
+ is_offscreen(false) {}
+
+PresentationSessionInfo::PresentationSessionInfo(
+ const GURL& presentation_url,
+ const std::string& presentation_id,
+ bool is_offscreen)
+ : presentation_url(presentation_url),
+ presentation_id(presentation_id),
+ is_offscreen(is_offscreen) {}
PresentationSessionInfo::~PresentationSessionInfo() {
}

Powered by Google App Engine
This is Rietveld 408576698