Issue 23797002: Hack to add accessors for WebIDL attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23797002: Hack to add accessors for WebIDL attributes. (Closed)

Created:
7 years, 3 months ago by arv (Not doing code reviews)

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Hack to add accessors for WebIDL attributes. The code gen for this is a big hack/copy-paste. BUG=43394

Patch Set 1 : #

Patch Set 2 : WIP #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+503 lines, -101 lines)			Patch
M	Source/bindings/scripts/IDLAttributes.txt	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/scripts/code_generator_v8.pm	View	1 2 3 4	33 chunks	+127 lines, -86 lines	0 comments	Download
M	Source/bindings/v8/V8DOMConfiguration.h	View	1 2 3 4	2 chunks	+20 lines, -1 line	0 comments	Download
M	Source/bindings/v8/V8DOMConfiguration.cpp	View	1	3 chunks	+35 lines, -3 lines	0 comments	Download
M	Source/core/dom/Document.idl	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.idl	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/dom/Node.idl	View	1 2 3 4	2 chunks	+10 lines, -7 lines	0 comments	Download
M	Source/core/dom/NodeList.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLDivElement.idl	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLElement.idl	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
A	move_attributes.html	View	1 2 3	1 chunk	+298 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

haraken

7 years, 2 months ago (2013-10-04 13:17:06 UTC) #1

The patch set 2 is doing the follow things:

- Define testAttrOn{Node,Element,HTMLElement,HTMLDivElement} on instances.

- Define testAttrOn{Node,Element,HTMLElement,HTMLDivElement}WithGetterAndSetter
on prototypes.

- move_attributes.html is a pathological micro-benchmark to compare performance
between the above testAttrs.

- Move all DOM attributes used in Dromaeo to prototypes.


In conclusion, I couldn't observe any perf regression in both the micro
benchmark and Dromaeo. Let me write a quick summary on Monday.

Expand Messages | Collapse Messages