Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2379633002: [runtime] Mark maps created as a result of field representation generalization as transition targets (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Mark maps created as a result of field type or representation generalization as migration targets. BUG=v8:5444 Review-Url: https://codereview.chromium.org/2379633002 Cr-Commit-Position: refs/heads/master@{#42307} Committed: https://chromium.googlesource.com/v8/v8/+/831994603b7c7b07040a05ebc0c983106df4c73c

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/objects.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-09-28 16:24:50 UTC) #7
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-29 12:56:02 UTC) #11
Jakob Kummerow
DBC: if there was a reason this didn't land, it would be nice to document ...
4 years ago (2016-12-19 22:43:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379633002/80001
3 years, 11 months ago (2017-01-13 07:50:29 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 08:17:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/831994603b7c7b07040a05ebc0c983106df...

Powered by Google App Engine
This is Rietveld 408576698