Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2379573002: [turbofan] Type::Contains() and Constants() is unnecessary. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Type::Contains() and Constants() is unnecessary. Cleanup. BUG= Committed: https://crrev.com/9686d0811e05f416427989b088609643e07c78e9 Cr-Commit-Position: refs/heads/master@{#39830}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -106 lines) Patch
M src/compiler/types.h View 2 chunks +0 lines, -29 lines 2 comments Download
M src/compiler/types.cc View 3 chunks +0 lines, -63 lines 0 comments Download
M test/cctest/test-types.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mvstanton
Hi Jaro, Here is a quick cleanup...
4 years, 2 months ago (2016-09-28 13:22:12 UTC) #2
Jarin
lgtm https://codereview.chromium.org/2379573002/diff/1/src/compiler/types.h File src/compiler/types.h (left): https://codereview.chromium.org/2379573002/diff/1/src/compiler/types.h#oldcode545 src/compiler/types.h:545: int NumConstants(); Is this necessary?
4 years, 2 months ago (2016-09-28 13:27:02 UTC) #5
mvstanton
thanks! https://codereview.chromium.org/2379573002/diff/1/src/compiler/types.h File src/compiler/types.h (left): https://codereview.chromium.org/2379573002/diff/1/src/compiler/types.h#oldcode545 src/compiler/types.h:545: int NumConstants(); On 2016/09/28 13:27:02, Jarin wrote: > ...
4 years, 2 months ago (2016-09-28 13:46:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379573002/1
4 years, 2 months ago (2016-09-28 14:06:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 14:09:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 14:09:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9686d0811e05f416427989b088609643e07c78e9
Cr-Commit-Position: refs/heads/master@{#39830}

Powered by Google App Engine
This is Rietveld 408576698