Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: test/cctest/test-types.cc

Issue 2379573002: [turbofan] Type::Contains() and Constants() is unnecessary. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/types.h ('K') | « src/compiler/types.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-types.cc
diff --git a/test/cctest/test-types.cc b/test/cctest/test-types.cc
index b620a7d2ff855c739b110a9b861b18c63eb74b63..dd1b3e370391fb76700b91bde60e36a90161be44 100644
--- a/test/cctest/test-types.cc
+++ b/test/cctest/test-types.cc
@@ -649,18 +649,6 @@ struct Tests {
CheckUnordered(T.UninitializedConstant, T.Undefined);
}
- void Contains() {
- // T->Contains(V) iff Constant(V)->Is(T)
- for (TypeIterator it = T.types.begin(); it != T.types.end(); ++it) {
- for (ValueIterator vt = T.values.begin(); vt != T.values.end(); ++vt) {
- Type* type = *it;
- Handle<i::Object> value = *vt;
- Type* const_type = T.Constant(value);
- CHECK(type->Contains(value) == const_type->Is(type));
- }
- }
- }
-
void Maybe() {
// T->Maybe(Any) iff T inhabited
for (TypeIterator it = T.types.begin(); it != T.types.end(); ++it) {
@@ -1105,8 +1093,6 @@ TEST(Is1) { Tests().Is1(); }
TEST(Is2) { Tests().Is2(); }
-TEST(Contains) { Tests().Contains(); }
-
TEST(Maybe) { Tests().Maybe(); }
TEST(Union1) { Tests().Union1(); }
« src/compiler/types.h ('K') | « src/compiler/types.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698