installer and some misc files: Change ScopedTempDir::path() to GetPath()

chrome/installer/util/copy_tree_work_item.h

Index: chrome/installer/util/copy_tree_work_item.h
diff --git a/chrome/installer/util/copy_tree_work_item.h b/chrome/installer/util/copy_tree_work_item.h
index dbfdfcc24ad34a0695af6a35a1d15749767edc0a..84dcb0f169cc2abd7bd4876603d94bd930672af5 100644
--- a/chrome/installer/util/copy_tree_work_item.h
+++ b/chrome/installer/util/copy_tree_work_item.h
@@ -77,7 +77,10 @@ class CopyTreeWorkItem : public WorkItem {
   bool copied_to_alternate_path_;
 
   // The temporary directory into which the original dest_path_ has been moved.
-  base::ScopedTempDir backup_path_;
+  base::ScopedTempDir backup_dir_;
+
+  // The path to |backup_dir_| or empty if |backup_dir_| has not been created.
+  base::FilePath backup_path_;

[vabr (Chromium), 2016/09/28 13:10:24]

Adding the path separately allows the CopyTreeWorkItem to keep track of whether
|backup_dir_| was initialised or not. It was possible to do so via the
deprecated path(), but by design it is not possible via the replacement
GetPath(). The point is to move the responsibility of not writing anything under
the empty path from ScopedTempDir to CopyTreeWorkItem.

 
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileSameContent);
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileInUse);