installer and some misc files: Change ScopedTempDir::path() to GetPath()

chrome/installer/util/copy_tree_work_item.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_COPY_TREE_WORK_ITEM_H_
 #define CHROME_INSTALLER_UTIL_COPY_TREE_WORK_ITEM_H_
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/gtest_prod_util.h"
@@ skipping 59 matching lines @@
 
   // Whether the original files have been moved to backup path under
   // temporary directory. If true, moving back is needed during rollback.
   bool moved_to_backup_;
 
   // Whether the source was copied to alternative_path_ because dest_path_
   // existed and was in use. Needed during rollback.
   bool copied_to_alternate_path_;
 
   // The temporary directory into which the original dest_path_ has been moved.
-  base::ScopedTempDir backup_path_;
+  base::ScopedTempDir backup_dir_;
+
+  // The path to |backup_dir_| or empty if |backup_dir_| has not been created.
+  base::FilePath backup_path_;

[vabr (Chromium), 2016/09/28 13:10:24]

Adding the path separately allows the CopyTreeWorkItem to keep track of whether
|backup_dir_| was initialised or not. It was possible to do so via the
deprecated path(), but by design it is not possible via the replacement
GetPath(). The point is to move the responsibility of not writing anything under
the empty path from ScopedTempDir to CopyTreeWorkItem.

 
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileSameContent);
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileInUse);
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileAndCleanup);
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, NewNameAndCopyTest);
   FRIEND_TEST_ALL_PREFIXES(CopyTreeWorkItemTest, CopyFileInUseAndCleanup);
 };
 
 #endif  // CHROME_INSTALLER_UTIL_COPY_TREE_WORK_ITEM_H_