Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2379453002:
Use SkPaintImageFilter of a bitmap to implement box reflection masks. (Closed)
|
Created:
4 years, 2 months ago by chrishtr Modified:
4 years, 2 months ago Reviewers:
Stephen White CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse SkPaintImageFilter of a bitmap to implement box reflection masks.
BUG=648055
Committed: https://crrev.com/9132e7071ba56be31591b2a9b5b31e6fe0adc3b1
Cr-Commit-Position: refs/heads/master@{#421875}
Patch Set 1 #
Total comments: 2
Patch Set 2 : none #
Total comments: 1
Patch Set 3 : none #
Total comments: 2
Patch Set 4 : Merge branch 'master' into fixboxreflect #
Messages
Total messages: 27 (14 generated)
Description was changed from ========== none none BUG= ========== to ========== Use SkPaintImageFilter of a bitmap to implement box reflection masks. BUG=648055 ==========
chrishtr@chromium.org changed reviewers: + senorblanco@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Seems reasonable, but it looks like something's off in fast/reflections/reflection-masks-outset.html (cullRect origin maybe?) https://codereview.chromium.org/2379453002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right): https://codereview.chromium.org/2379453002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119: SkPaintImageFilter::Make(paint), Alternatively, you could use an SkImageSource here, which will probably save a blit over using an SkPaintImageFilter (since it has a fast path to return the entire image). Not a huge deal, though.
https://codereview.chromium.org/2379453002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right): https://codereview.chromium.org/2379453002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119: SkPaintImageFilter::Make(paint), On 2016/09/28 at 14:02:02, Stephen White wrote: > Alternatively, you could use an SkImageSource here, which will probably save a blit over using an SkPaintImageFilter (since it has a fast path to return the entire image). Not a huge deal, though. Done.
If the bots are happy, it LGTM. https://codereview.chromium.org/2379453002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right): https://codereview.chromium.org/2379453002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:103: SkBitmap bitmap; BTW, if you want to avoid SkBitmap and go SkImage all the way, it'd look something like this: sk_sp<SkSurface> surface = SkSurface::MakeRaster(SkImageInfo::MakeN32Premul(w, h)); SkCanvas* canvas = surface->getCanvas(); ... sk_sp<SkImage> image = surface->makeImageSnapshot();
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/2379453002/#ps40001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2379453002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right): https://codereview.chromium.org/2379453002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:102: // encode it in an SkPaintImageFilter, which can be serialized. Nit: s/SkPaintImageFilter/SkImageSource/
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
https://codereview.chromium.org/2379453002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right): https://codereview.chromium.org/2379453002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:102: // encode it in an SkPaintImageFilter, which can be serialized. On 2016/09/28 at 19:51:35, Stephen White wrote: > Nit: s/SkPaintImageFilter/SkImageSource/ Done.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/2379453002/#ps60001 (title: "Merge branch 'master' into fixboxreflect")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Use SkPaintImageFilter of a bitmap to implement box reflection masks. BUG=648055 ========== to ========== Use SkPaintImageFilter of a bitmap to implement box reflection masks. BUG=648055 Committed: https://crrev.com/9132e7071ba56be31591b2a9b5b31e6fe0adc3b1 Cr-Commit-Position: refs/heads/master@{#421875} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9132e7071ba56be31591b2a9b5b31e6fe0adc3b1 Cr-Commit-Position: refs/heads/master@{#421875} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
