Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: chrome/browser/sync/test/integration/single_client_preferences_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/sync/test/integration/preferences_helper.h" 6 #include "chrome/browser/sync/test/integration/preferences_helper.h"
7 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 7 #include "chrome/browser/sync/test/integration/sync_test.h"
8 #include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h "
9 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
10 #include "components/browser_sync/profile_sync_service.h" 10 #include "components/browser_sync/profile_sync_service.h"
11 11
12 using preferences_helper::BooleanPrefMatches; 12 using preferences_helper::BooleanPrefMatches;
13 using preferences_helper::ChangeBooleanPref; 13 using preferences_helper::ChangeBooleanPref;
14 using sync_integration_test_util::AwaitCommitActivityCompletion;
15 14
16 class SingleClientPreferencesSyncTest : public SyncTest { 15 class SingleClientPreferencesSyncTest : public SyncTest {
17 public: 16 public:
18 SingleClientPreferencesSyncTest() : SyncTest(SINGLE_CLIENT) {} 17 SingleClientPreferencesSyncTest() : SyncTest(SINGLE_CLIENT) {}
19 ~SingleClientPreferencesSyncTest() override {} 18 ~SingleClientPreferencesSyncTest() override {}
20 19
21 private: 20 private:
22 DISALLOW_COPY_AND_ASSIGN(SingleClientPreferencesSyncTest); 21 DISALLOW_COPY_AND_ASSIGN(SingleClientPreferencesSyncTest);
23 }; 22 };
24 23
25 IN_PROC_BROWSER_TEST_F(SingleClientPreferencesSyncTest, Sanity) { 24 IN_PROC_BROWSER_TEST_F(SingleClientPreferencesSyncTest, Sanity) {
26 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 25 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
27 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage)); 26 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage));
28 ChangeBooleanPref(0, prefs::kHomePageIsNewTabPage); 27 ChangeBooleanPref(0, prefs::kHomePageIsNewTabPage);
29 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0))); 28 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
30 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage)); 29 ASSERT_TRUE(BooleanPrefMatches(prefs::kHomePageIsNewTabPage));
31 } 30 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698