Containing webview focus checks assume top level root.

Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or focused event targets with non-focused parents of root. The latter did not check whether the root was a top level root so we could have been checking focusability of anything if the root was an iframe. Ensure we're at a top level root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130
Committed: https://crrev.com/b4acbeb3d600b8fe4b75baf9c644b01815e8da31
Cr-Commit-Position: refs/heads/master@{#422479}

[David Tseng, 2016-09-30 17:09:43]

Description was changed from

==========
Containing webview focus checks assume top level root.
==========

to

==========
Containing webview focus checks assume top level root.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-30 17:12:50]

Description was changed from

==========
Containing webview focus checks assume top level root.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or
focused event targets with non-focused parents of root. The latter did not check
whether the root was a top level root so we could have been checking
focusability of anything if the root was an iframe. Ensure we're at a top level
root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130
==========

[David Tseng, 2016-09-30 17:12:50]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-09-30 18:44:00]

lgtm

Maybe grep through the code for other uses of root
that should be topRoot?

[David Tseng, 2016-10-03 17:24:53]

On 2016/09/30 18:44:00, dmazzoni wrote:
> lgtm
> 
> Maybe grep through the code for other uses of root
> that should be topRoot?

Good suggestion; most instances were checking whether the root was a desktop or
root web area. This one's the only instance looking specifically for the
webview.

[David Tseng, 2016-10-03 17:24:57]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-10-03 17:30:29]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-10-03 17:31:32]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:32:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:03:52]

Description was changed from

==========
Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or
focused event targets with non-focused parents of root. The latter did not check
whether the root was a top level root so we could have been checking
focusability of anything if the root was an iframe. Ensure we're at a top level
root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130
==========

to

==========
Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or
focused event targets with non-focused parents of root. The latter did not check
whether the root was a top level root so we could have been checking
focusability of anything if the root was an iframe. Ensure we're at a top level
root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130
==========

[commit-bot: I haz the power, 2016-10-03 19:03:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-03 19:07:25]

Description was changed from

==========
Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or
focused event targets with non-focused parents of root. The latter did not check
whether the root was a top level root so we could have been checking
focusability of anything if the root was an iframe. Ensure we're at a top level
root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130
==========

to

==========
Containing webview focus checks assume top level root.

Previously, we ignore editable text events on non-focused event targets or
focused event targets with non-focused parents of root. The latter did not check
whether the root was a top level root so we could have been checking
focusability of anything if the root was an iframe. Ensure we're at a top level
root and check the containing webview is focused.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=650130

Committed: https://crrev.com/b4acbeb3d600b8fe4b75baf9c644b01815e8da31
Cr-Commit-Position: refs/heads/master@{#422479}
==========

[commit-bot: I haz the power, 2016-10-03 19:07:26]

Patchset 1 (id:??) landed as
https://crrev.com/b4acbeb3d600b8fe4b75baf9c644b01815e8da31
Cr-Commit-Position: refs/heads/master@{#422479}