Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 2379423002: Containing webview focus checks assume top level root. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
index 550398551a36c7b93142193392f7fbcf8717dcab..424ba9610c804b1dae4054d0a3e9a7464355b59c 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
@@ -331,10 +331,11 @@ DesktopAutomationHandler.prototype = {
ChromeVoxState.instance.mode === ChromeVoxMode.CLASSIC)
return;
+ var topRoot = AutomationUtil.getTopLevelRoot(evt.target);
if (!evt.target.state.focused ||
- (evt.target.root.role != RoleType.desktop &&
- evt.target.root.parent &&
- !evt.target.root.parent.state.focused))
+ (topRoot &&
+ topRoot.parent &&
+ !topRoot.parent.state.focused))
return;
if (!ChromeVoxState.instance.currentRange) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698