Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2379343003: Revert of cc: Remove frame queuing from the scheduler. (Closed)

Created:
4 years, 2 months ago by brianderson
Modified:
4 years, 2 months ago
Reviewers:
danakj, sunnyps, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove frame queuing from the scheduler. (patchset #14 id:400001 of https://codereview.chromium.org/2339633003/ ) Reason for revert: Highly likely that this is causing the flakes we are seeing in http://crbug.com/645736 Original issue's description: > Reland of cc: Remove frame queuing from the scheduler. (patchset #1 id:1 of https://codereview.chromium.org/2336493002/ ) > > Reason for revert: > Reland after fixing screenshot grabber test and perf issues. > > Original issue's description: > > Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ ) > > > > Reason for revert: > > Broke ChromeScreenshotGrabberTest.TakeScreenshot on Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015. > > > > Original issue's description: > > > cc: Remove frame queuing from the scheduler. > > > > > > CC scheduler has a frame queuing mechanism called "retro frames". This > > > has been responsible for a lot of complexity and hard to fix bugs. The > > > original intent for adding retro frames was to allow the scheduler to > > > handle multiple frames in flight but that goal doesn't seem feasible or > > > even desirable any more. This CL removes the retro frames queue and > > > instead makes the Scheduler end the previous frame when it receives a > > > BeginFrame message. > > > > > > One surprising behavior was that SyntheticBFS MISSED frames would be > > > queued as retro frames and this would convert the synchronous begin > > > frame call (inside Scheduler::ProcessScheduledActions) to an > > > asynchronous retro frame PostTask. To work around this the Scheduler > > > keeps track of a single CancelableClosure that's used for MISSED frames. > > > > > > The above behavior was also causing the BeginFramesNotFromClient tests > > > to work even though there was an extra MISSED frame in the queue. This > > > is more elegantly solved in another way by using frame number to advance > > > the task runner instead of just running pending tasks. > > > > > > Lastly SchedulerStateMachine is modified so that it's possible to end > > > the previous frame and still have the same behavior as before in the > > > commit to active tree (browser compositor) mode. > > > > > > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org > > > BUG=602485, 644992 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > > > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78 > > > Cr-Commit-Position: refs/heads/master@{#417764} > > > > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=602485, 644992 > > > > Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd > > Cr-Commit-Position: refs/heads/master@{#417895} > > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sammc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=602485, 644992 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/864a70f6f93a87ff374bf2aea2494d4d7d0150d7 > Cr-Commit-Position: refs/heads/master@{#421268} TBR=enne@chromium.org,danakj@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602485, 644992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -225 lines) Patch
M cc/scheduler/scheduler.h View 3 chunks +5 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 10 chunks +127 lines, -69 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 13 chunks +41 lines, -42 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 3 chunks +63 lines, -58 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 5 chunks +413 lines, -36 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/test/test_compositor_frame_sink.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
brianderson
Created Revert of cc: Remove frame queuing from the scheduler.
4 years, 2 months ago (2016-09-30 23:44:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379343003/1
4 years, 2 months ago (2016-09-30 23:45:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/78531) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-30 23:48:47 UTC) #5
sunnyps
4 years, 2 months ago (2016-10-03 20:26:46 UTC) #6
I fixed the conflicts and uploaded a new revert here:
https://codereview.chromium.org/2386183003

Powered by Google App Engine
This is Rietveld 408576698