Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)
Patch Set: Fix silly typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 840a53be5658f13a052b4621ed58ce7776f20bdb..9da2a604734032c954318beaa3af6b7834b200be 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -474,6 +474,9 @@ void ChromeContentRendererClient::RenderFrameCreated(
// Only attach MainRenderFrameObserver to the main frame, since
// we only want to log page load metrics for the main frame.
new page_load_metrics::MetricsRenderFrameObserver(render_frame);
+ // Similarly, PageLoadHistograms are currently only collected for the main
+ // frame.
+ new PageLoadHistograms(render_frame);
} else {
// Avoid any race conditions from having the browser tell subframes that
// they're prerendering.
@@ -516,7 +519,6 @@ void ChromeContentRendererClient::RenderViewCreated(
#if defined(ENABLE_EXTENSIONS)
ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view);
#endif
- new PageLoadHistograms(render_view);
#if defined(ENABLE_PRINTING)
new printing::PrintWebViewHelper(
render_view, std::unique_ptr<printing::PrintWebViewHelper::Delegate>(
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698