Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)
Patch Set: Fix silly typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_content_renderer_client.h" 5 #include "chrome/renderer/chrome_content_renderer_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 #if defined(FULL_SAFE_BROWSING) 467 #if defined(FULL_SAFE_BROWSING)
468 safe_browsing::ThreatDOMDetails::Create(render_frame); 468 safe_browsing::ThreatDOMDetails::Create(render_frame);
469 #endif 469 #endif
470 470
471 new NetErrorHelper(render_frame); 471 new NetErrorHelper(render_frame);
472 472
473 if (render_frame->IsMainFrame()) { 473 if (render_frame->IsMainFrame()) {
474 // Only attach MainRenderFrameObserver to the main frame, since 474 // Only attach MainRenderFrameObserver to the main frame, since
475 // we only want to log page load metrics for the main frame. 475 // we only want to log page load metrics for the main frame.
476 new page_load_metrics::MetricsRenderFrameObserver(render_frame); 476 new page_load_metrics::MetricsRenderFrameObserver(render_frame);
477 // Similarly, PageLoadHistograms are currently only collected for the main
478 // frame.
479 new PageLoadHistograms(render_frame);
477 } else { 480 } else {
478 // Avoid any race conditions from having the browser tell subframes that 481 // Avoid any race conditions from having the browser tell subframes that
479 // they're prerendering. 482 // they're prerendering.
480 if (prerender::PrerenderHelper::IsPrerendering( 483 if (prerender::PrerenderHelper::IsPrerendering(
481 render_frame->GetRenderView()->GetMainRenderFrame())) { 484 render_frame->GetRenderView()->GetMainRenderFrame())) {
482 new prerender::PrerenderHelper(render_frame); 485 new prerender::PrerenderHelper(render_frame);
483 } 486 }
484 } 487 }
485 488
486 // Set up a mojo service to test if this page is a distiller page. 489 // Set up a mojo service to test if this page is a distiller page.
(...skipping 22 matching lines...) Expand all
509 new subresource_filter::SubresourceFilterAgent( 512 new subresource_filter::SubresourceFilterAgent(
510 render_frame, subresource_filter_ruleset_dealer_.get()); 513 render_frame, subresource_filter_ruleset_dealer_.get());
511 } 514 }
512 } 515 }
513 516
514 void ChromeContentRendererClient::RenderViewCreated( 517 void ChromeContentRendererClient::RenderViewCreated(
515 content::RenderView* render_view) { 518 content::RenderView* render_view) {
516 #if defined(ENABLE_EXTENSIONS) 519 #if defined(ENABLE_EXTENSIONS)
517 ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view); 520 ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view);
518 #endif 521 #endif
519 new PageLoadHistograms(render_view);
520 #if defined(ENABLE_PRINTING) 522 #if defined(ENABLE_PRINTING)
521 new printing::PrintWebViewHelper( 523 new printing::PrintWebViewHelper(
522 render_view, std::unique_ptr<printing::PrintWebViewHelper::Delegate>( 524 render_view, std::unique_ptr<printing::PrintWebViewHelper::Delegate>(
523 new ChromePrintWebViewHelperDelegate())); 525 new ChromePrintWebViewHelperDelegate()));
524 #endif 526 #endif
525 #if defined(ENABLE_SPELLCHECK) 527 #if defined(ENABLE_SPELLCHECK)
526 new SpellCheckProvider(render_view, spellcheck_.get()); 528 new SpellCheckProvider(render_view, spellcheck_.get());
527 #endif 529 #endif
528 new prerender::PrerendererClient(render_view); 530 new prerender::PrerendererClient(render_view);
529 531
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
1469 1471
1470 url::Replacements<char> r; 1472 url::Replacements<char> r;
1471 r.SetPath(path.c_str(), url::Component(0, path.length())); 1473 r.SetPath(path.c_str(), url::Component(0, path.length()));
1472 1474
1473 if (result == internal::NUM_PLUGIN_ERROR) 1475 if (result == internal::NUM_PLUGIN_ERROR)
1474 result = invalid_url ? internal::SUCCESS_PARAMS_REWRITE : internal::SUCCESS; 1476 result = invalid_url ? internal::SUCCESS_PARAMS_REWRITE : internal::SUCCESS;
1475 1477
1476 RecordYouTubeRewriteUMA(result); 1478 RecordYouTubeRewriteUMA(result);
1477 return corrected_url.ReplaceComponents(r); 1479 return corrected_url.ReplaceComponents(r);
1478 } 1480 }
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698