Issue 2379243002: [MD Settings] Fix dropdown menus inside expanded cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2379243002: [MD Settings] Fix dropdown menus inside expanded cards. (Closed)

Created:
4 years, 2 months ago by calamity

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[MD Settings] Fix dropdown menus inside expanded cards. Setting a border radius on an expanded card that has a z-index is causing some weird layer interactions that result in dropdown menus getting clipped in Mac. Let's just turn off border radius on expand... BUG=651344 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/settings/settings_page/settings_section.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2339523004 Patch 140001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

calamity

4 years, 2 months ago (2016-09-30 03:37:06 UTC) #1

Description was changed from

==========
[MD Settings] Fix dropdown menus inside expanded cards.

Setting a border radius on an expanded card that has a z-index is
causing some weird layer interactions that result in dropdown menus
getting clipped in Mac. Let's just turn off border radius on expand...

BUG=651344
==========

to

==========
[MD Settings] Fix dropdown menus inside expanded cards.

Setting a border radius on an expanded card that has a z-index is
causing some weird layer interactions that result in dropdown menus
getting clipped in Mac. Let's just turn off border radius on expand...

BUG=651344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages