Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gpu/config/gpu_control_list.cc

Issue 2379153002: GpuControlListEntry might need more info for gl_version as well (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/config/gpu_control_list_entry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_control_list.cc
diff --git a/gpu/config/gpu_control_list.cc b/gpu/config/gpu_control_list.cc
index 3fcb03f333f2e62762112d58f4f59f15ce1bbdb8..98d5409a25b498a5f0aa6c855cbac7751989d6b5 100644
--- a/gpu/config/gpu_control_list.cc
+++ b/gpu/config/gpu_control_list.cc
@@ -1336,8 +1336,10 @@ bool GpuControlList::GpuControlListEntry::NeedsMoreInfo(
return true;
if (driver_version_info_.get() && gpu_info.driver_version.empty())
return true;
- if (!gl_version_string_info_.empty() && gpu_info.gl_version.empty())
+ if ((gl_version_info_.get() || !gl_version_string_info_.empty()) &&
+ gpu_info.gl_version.empty()) {
return true;
+ }
if (!gl_vendor_info_.empty() && gpu_info.gl_vendor.empty())
return true;
if (!gl_renderer_info_.empty() && gpu_info.gl_renderer.empty())
« no previous file with comments | « no previous file | gpu/config/gpu_control_list_entry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698