Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: gpu/config/gpu_control_list.cc

Issue 2379153002: GpuControlListEntry might need more info for gl_version as well (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gpu/config/gpu_control_list_entry_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/config/gpu_control_list.h" 5 #include "gpu/config/gpu_control_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 1318 matching lines...) Expand 10 before | Expand all | Expand 10 after
1329 const GPUInfo& gpu_info, 1329 const GPUInfo& gpu_info,
1330 bool consider_exceptions) const { 1330 bool consider_exceptions) const {
1331 // We only check for missing info that might be collected with a gl context. 1331 // We only check for missing info that might be collected with a gl context.
1332 // If certain info is missing due to some error, say, we fail to collect 1332 // If certain info is missing due to some error, say, we fail to collect
1333 // vendor_id/device_id, then even if we launch GPU process and create a gl 1333 // vendor_id/device_id, then even if we launch GPU process and create a gl
1334 // context, we won't gather such missing info, so we still return false. 1334 // context, we won't gather such missing info, so we still return false.
1335 if (!driver_vendor_info_.empty() && gpu_info.driver_vendor.empty()) 1335 if (!driver_vendor_info_.empty() && gpu_info.driver_vendor.empty())
1336 return true; 1336 return true;
1337 if (driver_version_info_.get() && gpu_info.driver_version.empty()) 1337 if (driver_version_info_.get() && gpu_info.driver_version.empty())
1338 return true; 1338 return true;
1339 if (!gl_version_string_info_.empty() && gpu_info.gl_version.empty()) 1339 if ((gl_version_info_.get() || !gl_version_string_info_.empty()) &&
1340 gpu_info.gl_version.empty()) {
1340 return true; 1341 return true;
1342 }
1341 if (!gl_vendor_info_.empty() && gpu_info.gl_vendor.empty()) 1343 if (!gl_vendor_info_.empty() && gpu_info.gl_vendor.empty())
1342 return true; 1344 return true;
1343 if (!gl_renderer_info_.empty() && gpu_info.gl_renderer.empty()) 1345 if (!gl_renderer_info_.empty() && gpu_info.gl_renderer.empty())
1344 return true; 1346 return true;
1345 1347
1346 if (consider_exceptions) { 1348 if (consider_exceptions) {
1347 for (size_t i = 0; i < exceptions_.size(); ++i) { 1349 for (size_t i = 0; i < exceptions_.size(); ++i) {
1348 if (exceptions_[i]->NeedsMoreInfo(gpu_info, consider_exceptions)) 1350 if (exceptions_[i]->NeedsMoreInfo(gpu_info, consider_exceptions))
1349 return true; 1351 return true;
1350 } 1352 }
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1632 const std::string& feature_name, int feature_id) { 1634 const std::string& feature_name, int feature_id) {
1633 feature_map_[feature_name] = feature_id; 1635 feature_map_[feature_name] = feature_id;
1634 } 1636 }
1635 1637
1636 void GpuControlList::set_supports_feature_type_all(bool supported) { 1638 void GpuControlList::set_supports_feature_type_all(bool supported) {
1637 supports_feature_type_all_ = supported; 1639 supports_feature_type_all_ = supported;
1638 } 1640 }
1639 1641
1640 } // namespace gpu 1642 } // namespace gpu
1641 1643
OLDNEW
« no previous file with comments | « no previous file | gpu/config/gpu_control_list_entry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698