Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2379073002: perf: Speculative fix for tough_webgl_ad_cases (Closed)

Created:
4 years, 2 months ago by Sami
Modified:
4 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Speculative fix for tough_webgl_ad_cases Committed: https://crrev.com/df8688b9fbb6140e0c9093aaa5240e6252fe9e00 Cr-Commit-Position: refs/heads/master@{#421894}

Patch Set 1 #

Patch Set 2 : CL for src perf tryjob to run smoothness.tough_webgl_ad_cases benchmark on android-nexus5X platform… #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/page_sets/tough_ad_cases.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
CL for src perf tryjob to run smoothness.tough_webgl_ad_cases benchmark on android-nexus5X platform(s)
4 years, 2 months ago (2016-09-29 15:49:21 UTC) #1
Sami
Perf try bot seems happy with this so I'd like to give this a spin ...
4 years, 2 months ago (2016-09-29 17:54:40 UTC) #4
nednguyen
lgtm
4 years, 2 months ago (2016-09-29 17:59:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379073002/40001
4 years, 2 months ago (2016-09-29 18:03:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 19:07:18 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/df8688b9fbb6140e0c9093aaa5240e6252fe9e00 Cr-Commit-Position: refs/heads/master@{#421894}
4 years, 2 months ago (2016-09-29 19:12:15 UTC) #13
Sami
4 years, 2 months ago (2016-09-30 09:15:28 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2386583002/ by skyostil@chromium.org.

The reason for reverting is: Doesn't look like this made a difference..

Powered by Google App Engine
This is Rietveld 408576698