Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2379033002: Move core/fpdfapi/fpdf_page/include to core/fpdfapi/fpdf_page (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdfapi/fpdf_page/include to core/fpdfapi/fpdf_page BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/8a752ab21daa2dcd0314ab5e3908f8d6e7bba2b7

Patch Set 1 #

Patch Set 2 : Header sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -1247 lines) Patch
M BUILD.gn View 3 chunks +16 lines, -16 lines 0 comments Download
M core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3char.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_clippath.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_clippath.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_color.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_color.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_colorspace.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_countedobject.h View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_form.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_form.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_formobject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_formobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_generalstate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_generalstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_graphicstates.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_image.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_imageobject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_imageobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_meshstream.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_page.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_page.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pagemodule.h View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_pageobject.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pageobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_pageobjectholder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pageobjectholder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_path.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_pathobject.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pathobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_shadingobject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_textobject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_textstate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_tilingpattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_clippath.h View 1 chunk +0 lines, -63 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_color.h View 1 chunk +0 lines, -41 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_colorspace.h View 1 chunk +0 lines, -121 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_form.h View 1 chunk +0 lines, -41 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_formobject.h View 1 chunk +0 lines, -37 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_generalstate.h View 1 chunk +0 lines, -109 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_image.h View 1 chunk +0 lines, -90 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_imageobject.h View 1 chunk +0 lines, -44 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_page.h View 1 chunk +0 lines, -69 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_pageobject.h View 1 chunk +0 lines, -71 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_pageobjectholder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 chunk +0 lines, -50 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_pathobject.h View 1 chunk +0 lines, -36 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_shadingobject.h View 1 chunk +0 lines, -34 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_textobject.h View 1 chunk +0 lines, -69 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_textstate.h View 1 chunk +0 lines, -91 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_annotlist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_formcontrol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_linklist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_occontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cba_annotiterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_pageview.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2375283003 Patch 1

Dependent Patchsets:

Issue 2383543002 Patch 1

Messages

Total messages: 13 (9 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 14:30:29 UTC) #6
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:29:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379033002/20001
4 years, 2 months ago (2016-09-29 18:59:20 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 19:00:02 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8a752ab21daa2dcd0314ab5e3908f8d6e7bb...

Powered by Google App Engine
This is Rietveld 408576698