Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2375283003: Move core/fpdfapi/fpdf_font/include to core/fpdfapi/fpdf_font (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdfapi/fpdf_font/include to core/fpdfapi/fpdf_font BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/166bc16e15a5be72fe19da97504b4837967333ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -235 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/fpdf_font/cpdf_font.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/fpdf_font/cpdf_fontencoding.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_fontencoding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.h View 1 chunk +2 lines, -2 lines 0 comments Download
D core/fpdfapi/fpdf_font/include/cpdf_font.h View 1 chunk +0 lines, -132 lines 0 comments Download
D core/fpdfapi/fpdf_font/include/cpdf_fontencoding.h View 1 chunk +0 lines, -61 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_variabletext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_unicodeencodingex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2381863003 Patch 1

Dependent Patchsets:

Issue 2379033002 Patch 1
Issue 2379033002 Patch 20001

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 14:12:56 UTC) #4
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:14:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375283003/1
4 years, 2 months ago (2016-09-29 18:58:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 18:58:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/166bc16e15a5be72fe19da97504b48379673...

Powered by Google App Engine
This is Rietveld 408576698