Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: test/module/src/module.gyp

Issue 23789004: ninja&make/mac: Give loadable_modules type MH_BUNDLE. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/xcode_emulation.py ('K') | « test/mac/gyptest-loadable-module.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/module/src/module.gyp
===================================================================
--- test/module/src/module.gyp (revision 1715)
+++ test/module/src/module.gyp (working copy)
@@ -36,7 +36,6 @@
'type': 'loadable_module',
'product_name': 'lib1',
'product_prefix': '',
- 'xcode_settings': {'OTHER_LDFLAGS': ['-dynamiclib'], 'MACH_O_TYPE': ''},
Nico 2013/09/05 04:36:21 Not sure what this was for. mmoss added it in http
Michael Moss 2013/09/05 15:00:16 I don't know much about xcode, so I probably eithe
'sources': [
'lib1.c',
],
@@ -46,7 +45,6 @@
'product_name': 'lib2',
'product_prefix': '',
'type': 'loadable_module',
- 'xcode_settings': {'OTHER_LDFLAGS': ['-dynamiclib'], 'MACH_O_TYPE': ''},
'sources': [
'lib2.c',
],
« pylib/gyp/xcode_emulation.py ('K') | « test/mac/gyptest-loadable-module.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698